Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix git workflow #13

Merged
merged 5 commits into from
Mar 19, 2024
Merged

Fix git workflow #13

merged 5 commits into from
Mar 19, 2024

Conversation

Tanya-atatakai
Copy link
Collaborator

@Tanya-atatakai Tanya-atatakai commented Mar 15, 2024 •
edited
Loading

Proposed changes

Fix git workflow, split into two separate configs for tokenomics and registry apps

Fixes

  1. currently tests for registry are commented because they are failing and need to be fixed. we can enable once tests are working
  2. gitleaks for both apps throw errors, I added --exit-code 0 but need to remove once all issues are fixed
image

Types of changes

What types of changes does your code introduce?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

@vercel Vercel
Copy link

vercel bot commented Mar 15, 2024

Someone is attempting to deploy this pull request to the autonolas Team on Vercel.

To accomplish this, the commit author's email address needs to be associated with a GitHub account.

Learn more about how to change the commit author information.

@Tanya-atatakai Tanya-atatakai force-pushed the fix/git-workflow branch 8 times, most recently from 25df07d to 68ce060 Compare March 15, 2024 16:06
@Tanya-atatakai Tanya-atatakai force-pushed the fix/git-workflow branch 2 times, most recently from c38e0b8 to ad6ed55 Compare March 17, 2024 21:23
@Tanya-atatakai Tanya-atatakai changed the title [WIP] Fix git workflow Fix git workflow Mar 18, 2024
@Tanya-atatakai Tanya-atatakai changed the base branch from main to mohan/registry-test-cases March 19, 2024 08:50
@mohandast52 mohandast52 merged commit c94348e into mohan/registry-test-cases Mar 19, 2024
4 of 6 checks passed
@mohandast52 mohandast52 deleted the fix/git-workflow branch March 19, 2024 08:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mohandast52 mohandast52 Awaiting requested review from mohandast52

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Tanya-atatakai @mohandast52